Aayush lessons learned hover ghost bar graph#4461
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
VijayAnirudh
left a comment
There was a problem hiding this comment.
### Review Summary ✅
Tested the aayush_lessons_learned_hover_ghost_bar_graph branch locally:
-
Graph Rendering
- Verified that when
chartDatais empty, the bar chart no longer renders a ghost/empty graph. - When valid data exists, the chart displays correctly with proper alignment and labels.
- Verified that when
-
Error & Loading States
- Confirmed that
Loading…andErrormessages display appropriately. - No console warnings or runtime errors observed.
- Confirmed that
-
Code Quality
- ESLint warning resolved in
Header.jsx(unused variable removed). - Minor cleanup in
yarn.lockapplied without breaking dependencies.
- ESLint warning resolved in
-
Deploy Preview
- Netlify preview matches local behavior — ghost graph issue is resolved and UI remains consistent.
Conclusion
All acceptance criteria have been met:
- Ghost graph no longer appears when no data is available.
- Graph renders correctly when data exists.
- Code cleanup and ESLint fixes applied.
Approving this PR ✅
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Aayush,
I have reviewed your PR locally, though when selecting date's the chart does not render a ghost graph but when the date filter is not selected, we can see ghost bar graph. Assuming this is an acceptable scenario, there is also space left for the graph in terms of no ghost graphs, so i am requesting changes in the PR.


|
saitejakaasoju
left a comment
There was a problem hiding this comment.
Hi Aayush,
I tested this PR locally following the “How to test” steps. In Lessons Learned -> Injury Severity by Category of Worker Injured, the graph renders when data is available (e.g., with default/no specific filters), and when there is no data the page shows “No data for selected filters”, no graph/hover ghost bar is displayed. Looks good to merge.
|
Thank you all, merging! |













Description
Related PRS (if any):
#3619
…
Main changes explained:
…
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Recording.2025-11-26.234413.mp4